Feature/support bazarr #214

phyzical · 2023-09-23T04:44:26Z

Description of the change
Support Bazarr metrics

Most of the changes are isolated to bazarr specific code flow except the change around the param handling,

I think this change should be safe as itll just work as it did before without any ,

This was required as i couldn't figure out any way to provide multiple ids to the same parameter. as without it the pull was talking around 10 minutes (getting all series, looping all series then having to get all episodes then looping those ), after pulling all episodes at once it went down to 20 seconds and bazaars api doesnt support getting all items.

Also added a makefile for quick dev "up and go", but i can revert this and add it to the gitignore if you prefer

Possible drawbacks
requires changes in morpheus65535/bazarr#2252 to support filesize and support /v1

Applicable issues
closes #6

Additional information

Still need todo the tests but wanted to get some eyes on this in its current state.

i gave async a go (similar to how the sab collector does things) but it actually ran slower so i ditched those changes.

it sits at around 210/220 MB when its scrapping incase memory needs to be benchmarked

Also this is my second time playing with golang so i open to any feedback

Thanks!

feature/support-bazarr

internal/client/client.go

onedr0p · 2023-09-23T07:31:19Z

I'll have a closer look at this early October when I'm back home unless @rtrox has some free time. Sorry for the delay

phyzical · 2023-09-23T07:32:30Z

@onedr0p no rush :)

phyzical · 2023-09-25T06:43:28Z

Question for when you review, would it be okay to lax the requirement for an api version? turns out aliasing the api is impossible bazarr side due to the framework it uses just does not allowing alaising for some reason..

onedr0p · 2023-09-25T10:45:42Z

I believe that should be fine, bazarr is a bit bizarre so I'm sure there are some things like this that don't carry over from the other arr apps that well.

feature/support-bazarr

README.md

phyzical · 2023-09-26T08:19:00Z

.github/workflows/ci.yml

@@ -24,7 +22,7 @@ jobs:
  release-image:
    runs-on: ubuntu-latest
    needs: tests
-    if: github.event_name == 'push'
+    if: github.event_name == 'push' && github.ref_name == 'master'
    steps:


These changes should mean it'll run the tests per commit but shouldn't try to make a release.

Can revert if preferred

Looks good to me!

wait, actually -- this change is a problem :-/ . The on conditions in an action are an OR between it's children, so it was already running on pushes to master OR pull_requests, with the if condition here ensuring that we only released images on a push to master.

So what this change is actually doing is making it so that we'll only run this workflow on pull_requests, and therefore never build images inside this workflow (so the only built images would come from the tagged release workflow, we'd have no updates to the master tag).

Let's revert this file, everything else looks good.

feature/support-bazarr

… result feature/support-bazarr

internal/arr/collector/bazarr_test.go

.env.dist

.gitignore

onedr0p

Nice work here @phyzical I'll merge this if you don't have any other commits to send over. Also should be mentioned that I do not run bazarr so hopefully I can lean on the community here to keep this integration working.

internal/client/client.go

internal/arr/collector/bazarr_test.go

rtrox · 2023-10-03T21:19:27Z

makefile

@@ -0,0 +1,15 @@
+-include .env


👍 Adding a makefile is a good idea, thanks!

rtrox · 2023-10-03T21:21:51Z

The test failure is just yelling because go.mod isn't consistent with the code. if you run go mod tidy real quick, that test should pass.

phyzical · 2023-10-04T01:51:58Z

thanks for the reviews gang

@onedr0p no more code to commit.

i agree interms of maintenance feel free to ping me if there are issues with the bazarr provider reported.

ill fix up the tests later today

…r into feature/support-bazarr feature/support-bazarr

rtrox

Whoops, just realized I hadn't stamped this. @onedr0p I looked through the most recent commits. I'm good with pushing this if you are. I'll leave it to you to merge given the size of the feature.

rtrox · 2023-10-08T00:35:58Z

.github/workflows/ci.yml

@@ -24,7 +22,7 @@ jobs:
  release-image:
    runs-on: ubuntu-latest
    needs: tests
-    if: github.event_name == 'push'
+    if: github.event_name == 'push' && github.ref_name == 'master'
    steps:


wait, actually -- this change is a problem :-/ . The on conditions in an action are an OR between it's children, so it was already running on pushes to master OR pull_requests, with the if condition here ensuring that we only released images on a push to master.

So what this change is actually doing is making it so that we'll only run this workflow on pull_requests, and therefore never build images inside this workflow (so the only built images would come from the tagged release workflow, we'd have no updates to the master tag).

Let's revert this file, everything else looks good.

phyzical · 2023-10-08T08:37:31Z

@rtrox my bad, i initially made the change to the workflow thinking it would let me run tests per commit. then forgot that it wasn't actually running due to me not being a valid contributor yet.

Will update the tests for the rest of the providers in a few days and revert that change if it isnt done already

phyzical added 12 commits September 12, 2023 15:21

remove the branch requirement to run tests

1c19cdf

feature/support-bazarr

lint makefile

376ad1b

feature/support-bazarr

add bazarr to readme

2f87008

feature/support-bazarr

also comment out release image as we only want tests to happen

cbbcc5e

feature/support-bazarr

initial changes to start attempting to pull bazarr i thinnk?

bb45c0d

feature/support-bazarr

make it only run the tests, but skip release image

ffe95c5

feature/support-bazarr

add a genric makefile to build container localy, run and test

8615eab

feature/support-bazarr

rename build command

c277a68

feature/support-bazarr

add pic and grafana dashboard adjustments

9459374

feature/support-bazarr

refactor metrics to just be contained within 1 class

41f16d9

add logic to allow csv values to params

7c4bcce

remove some todos

099f367

phyzical requested a review from onedr0p as a code owner September 23, 2023 04:44

phyzical commented Sep 23, 2023

View reviewed changes

internal/client/client.go Outdated Show resolved Hide resolved

phyzical added 3 commits September 26, 2023 16:14

make api version optional

5a928d5

feature/support-bazarr

adjust makefile to auto kill and start

2c79ae1

feature/support-bazarr

remove now invalid test

be603a5

feature/support-bazarr

phyzical commented Sep 26, 2023

View reviewed changes

README.md Show resolved Hide resolved

phyzical commented Sep 26, 2023

View reviewed changes

phyzical added 3 commits September 26, 2023 16:59

add a test for no api version instead

90b2c90

feature/support-bazarr

add a test to enforce csv params moving forward

f5e33fd

feature/support-bazarr

add saml payloads for all endpoints, add test that mocks and verifies…

1407062

… result feature/support-bazarr

phyzical commented Sep 26, 2023

View reviewed changes

internal/arr/collector/bazarr_test.go Show resolved Hide resolved

onedr0p reviewed Oct 3, 2023

View reviewed changes

.env.dist Outdated Show resolved Hide resolved

Update .env.dist

8cba7cf

onedr0p reviewed Oct 3, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

Update .gitignore

c7345f0

onedr0p approved these changes Oct 3, 2023

View reviewed changes

rtrox reviewed Oct 3, 2023

View reviewed changes

phyzical added 3 commits October 4, 2023 10:01

Update internal/client/client.go

e8d3181

add a tidy task

374431e

Merge branch 'feature/support-bazarr' of github.com:phyzical/exportar…

c6930a7

…r into feature/support-bazarr feature/support-bazarr

rtrox approved these changes Oct 8, 2023

View reviewed changes

rtrox requested changes Oct 8, 2023

View reviewed changes

onedr0p approved these changes Oct 8, 2023

View reviewed changes

onedr0p merged commit b8b7cc6 into onedr0p:master Oct 8, 2023
2 checks passed

rtrox mentioned this pull request Oct 8, 2023

Separate PR & Merge Workflows #225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/support bazarr #214

Feature/support bazarr #214

phyzical commented Sep 23, 2023 •

edited

Loading

onedr0p commented Sep 23, 2023 •

edited

Loading

phyzical commented Sep 23, 2023

phyzical commented Sep 25, 2023

onedr0p commented Sep 25, 2023 •

edited

Loading

phyzical Sep 26, 2023

onedr0p Oct 3, 2023

rtrox Oct 8, 2023 •

edited

Loading

onedr0p left a comment •

edited

Loading

rtrox Oct 3, 2023

rtrox commented Oct 3, 2023

phyzical commented Oct 4, 2023

rtrox left a comment

rtrox Oct 8, 2023 •

edited

Loading

phyzical commented Oct 8, 2023

Feature/support bazarr #214

Feature/support bazarr #214

Conversation

phyzical commented Sep 23, 2023 • edited Loading

onedr0p commented Sep 23, 2023 • edited Loading

phyzical commented Sep 23, 2023

phyzical commented Sep 25, 2023

onedr0p commented Sep 25, 2023 • edited Loading

phyzical Sep 26, 2023

Choose a reason for hiding this comment

onedr0p Oct 3, 2023

Choose a reason for hiding this comment

rtrox Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

onedr0p left a comment • edited Loading

Choose a reason for hiding this comment

rtrox Oct 3, 2023

Choose a reason for hiding this comment

rtrox commented Oct 3, 2023

phyzical commented Oct 4, 2023

rtrox left a comment

Choose a reason for hiding this comment

rtrox Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

phyzical commented Oct 8, 2023

phyzical commented Sep 23, 2023 •

edited

Loading

onedr0p commented Sep 23, 2023 •

edited

Loading

onedr0p commented Sep 25, 2023 •

edited

Loading

rtrox Oct 8, 2023 •

edited

Loading

onedr0p left a comment •

edited

Loading

rtrox Oct 8, 2023 •

edited

Loading